All, I have fixed a couple errors in installadm-common.sh . These fixes were done after I looked at the webrev and saw the mistakes. The mistakes were not in the original version that I had tested but Clay asked me to make it ksh93 compliant and I did it a little too quickly.
The changes are as follows: line 331: changed to -z like it should be since -f wouldn't do anything useful, also included space line 444: added -z again so that it would actually work. This was my fault as I didn't proofread or test the last changes before we posted this. Thank you, Andrew Gracey On Thu, Sep 16, 2010 at 3:06 PM, Keith Mitchell <[email protected]>wrote: > Hi guys, > > Since we are going to be making the GRUB changes, I think you should > follow-up and explicitly ask for review of those changes. > > Adding my comments here; you may want to address them before asking for > review. > > dc_defs.py (and elsewhere): > I'd propose a more generic term here for this keyword, as theoretically one > could use this functionality in a stock AI image, correct? Something like > "NO_INSTALL_GRUB_TITLE" or "BOOT_IMAGE_GRUB_TITLE" perhaps. (The keyword is > internal, so it doesn't need to be perfect, especially since this will > likely all change when we implement usage of Grub2). > > installadm-common.sh: > Nit, line 330, need a space after "-f" > > Update get_grub_text_title() function name to be slightly more generic. > > - Keith > > Thank you all for the comments. We have updated all of your concerns that > you mentioned into our new webrev: > http://cr.opensolaris.org/~chris_n/netboot_text_install_v2/<http://cr.opensolaris.org/%7Echris_n/netboot_text_install_v2/> > > and the updated parts located at: > http://cr.opensolaris.org/~chris_n/netboot_text_install_part/<http://cr.opensolaris.org/%7Echris_n/netboot_text_install_part/> > > To address specific concerns: > > - ict.py: The check was added to give additional debugging statements. > Install finish was also now modified so that the packages to remove are the > exact same for text and auto install. This check will prevent an error > later > down from trying to uninstall a package that is not there. > > > - We made modifications to installadm and to the finalizer script that > generates .image_info so that if it is a net-text image installadm would > generate a new GRUB menu to represent that the default choice is now text > install. We were looking for feedback if this is the right way to go. If we > change the GRUB menu some users may get confused when they boot it up for > the sole purpose of getting dropped into a console and see <release> Text > Install. However a user who wants to use it to do a text install may also > get confused if it doesn't say anything except <release> boot image. Does > anybody have an alternative or feel strongly one way or the other? > > We would appreciate any additional feedback. > > Thanks, > Chris & Andrew > > > > > On Tue, Aug 31, 2010 at 1:35 PM, Chris Navrides <[email protected]>wrote: > >> Hi all, >> >> Could we please get a code review of the modifications made to >> enable 6971585 Network Text Install >> >> This will enable a client over the network to either do an Automated >> Install or a Text Install. The default in the grub menu will lead to the >> text install menu. For sparc if no "-install" flag is set then it will also >> default to the text-install menu. >> >> Webrev: >> http://cr.opensolaris.org/~chris_n/netboot_text_instal<http://cr.opensolaris.org/%7Echris_n/netboot_text_install/> >> l/ <http://cr.opensolaris.org/%7Echris_n/netboot_text_install/> >> >> We have done testing with both x86 and sparc using the test bed on the >> 10.10.45 subnet. There are no changes done to installadm on the server side. >> >> Thanks, >> Chris & Andrew >> > > > _______________________________________________ > caiman-discuss mailing list > [email protected]http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > >
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
