Hi Ethan, Looks fine to me.
Nit: I think that it might be useful to include the table you presented below in the comments as an example... Thanks, Darren. On 09/17/10 03:25 AM, Ethan Quach wrote: > Can I get a couple of reviewers for this. > > 6978639 Default net AI install on x86 with 1GB or less memory no longer works > when installing from /dev repo > > http://cr.opensolaris.org/~equach/webrev.6978639/ > > > This fix effectively increases the amount of swap zvol that > gets created for systems with physical memory between > 786MB =< mem < 1.5G. The code basically enforces that > systems in this range have a total of 2G virtual memory. > > Systems with 512MB RAM are unchanged. They continue to > get configured with a UFS slice for swap. > > Systems with 1.5G RAM or larger are unchanged. They > currently get (1/2 * mem) added as swap, which already > puts them above the 2G mark. > > > The following is a table of the swap that will get created when > installing on a 16G disk. The lines in red highlight what changed. > These changes apply to both LiveCD and AI (Sparc and X86). > (The non traditional mem sizes were not tested on Sparc.) > > > Phys Mem Prev swap New swap > ---------------------------------------------------------------- > 512MB 1G ufs 1G ufs > 786MB 512MB zvol 1.26G zvol > 1024MB 512MB zvol 1G zvol > 1280MB 680MB zvol 721MB zvol > 1536MB 767MB zvol 767MB zvol > 1792MB 895MB zvol 895MB zvol > 2048MB 1G zvol 1G zvol > > > thanks, > -ethan > > > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
