Keith,
Thanks for the review.
-ethan
On 09/17/10 09:53, Keith Mitchell wrote:
Hi Ethan,
No, the text installer doesn't need to mimic the other installers. I
simply jumped to the wrong conclusion when you stated that this change
affected the liveCD. Everything looks good now, thanks.
- Keith
----- Original Message -----
From: [email protected]
To: [email protected]
Cc: [email protected]
Sent: Friday, September 17, 2010 9:27:41 AM GMT -08:00 US/Canada Pacific
Subject: Re: [caiman-discuss] code review for 6978639
On 09/17/10 08:24, Keith Mitchell wrote:
Hi Ethan,
Does the text installer need to be updated as well? The relevant
code is under:
usr/src/cmd/text-install/osol_install/text_install/ti_install_utils.py
The text installer doesn't need to be updated and neither did the
LiveCD, but since the code being modified here is shared by AI and
the LiveCD, it gets impacted as well and I didn't really want to diverge
this code for AI vs LiveCD.
In looking at the text installer's code, it looks to be a copy of the
logic from liborchestrator. If we really need to keep these consistent,
then I can make the corresponding changes to the text installer as
well. (Was this part of the plan when we copied this logic for the
text installer?)
In the long run, when we move our apps over to using the new engine,
this logic would seem to be per-app though, rather than being shared.
thanks,
-ethan
- Keith
----- Original Message -----
From: [email protected]
To: [email protected]
Sent: Thursday, September 16, 2010 7:27:56 PM GMT -08:00 US/Canada
Pacific
Subject: [caiman-discuss] code review for 6978639
Can I get a couple of reviewers for this.
6978639 Default net AI install on x86 with 1GB or less memory no
longer works when installing from /dev repo
http://cr.opensolaris.org/~equach/webrev.6978639/
This fix effectively increases the amount of swap zvol that
gets created for systems with physical memory between
786MB =< mem < 1.5G. The code basically enforces that
systems in this range have a total of 2G virtual memory.
Systems with 512MB RAM are unchanged. They continue to
get configured with a UFS slice for swap.
Systems with 1.5G RAM or larger are unchanged. They
currently get (1/2 * mem) added as swap, which already
puts them above the 2G mark.
The following is a table of the swap that will get created when
installing on a 16G disk. The lines in red highlight what changed.
These changes apply to both LiveCD and AI (Sparc and X86).
(The non traditional mem sizes were not tested on Sparc.)
Phys Mem Prev swap New swap
----------------------------------------------------------------
512MB 1G ufs 1G ufs
786MB 512MB zvol 1.26G zvol
1024MB 512MB zvol 1G zvol
1280MB 680MB zvol 721MB zvol
1536MB 767MB zvol 767MB zvol
1792MB 895MB zvol 895MB zvol
2048MB 1G zvol 1G zvol
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
