http://cr.opensolaris.org/~comay/webrev-12737/SlimInstall: - While you're doing the restructuring, could you put a blank line before the definition of babel_install?
Done.
- And shouldn't we just make babel_install a renamed package by now?
I had that in an earlier webrev but given that there's a slight possibility we could reintroduce a Live CD with more languages, I decided to hold off on the real renaming for now especially given that all of these packages need to have hierarchical names. Also, the subsequent name changes will necessitate AI & DC manifest updates, so I'd prefer to leave it as-is for now.
- Where do the includes come from? That is, how do you do a slim import now? Would this be more apparent once you have a full build 150 sync, that has a slim_cluster file, or is that disappearing? I'm also not sure how you end up importing the AI and TI clusters.
Good question. I checked with the Install folks who I believed were the main consumer of doing just a slim_import and they said they no longer needed this capability. As such, I'm proposing taking this away and as such, I'm not carrying forward the slim_cluster file forward into the build. In short, doing a "redist_import" will cause the leaf packages plus all of the defined group packages to be imported. I know this doesn't allow for easy importing of a group package and its dependencies but my hope is this will be easier once more or less everyone is delivering IPS repos natively.
- Could you change "description" to "summary"? If we only have one, it should be the latter. This applies to all the cluster packages.
Done. Thanks for the review. _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
