Hi Karen, On Thu, 21 Oct 2010, Karen Tung wrote:
Please review the *prototype-quality* files the engine and DC project require from the target instantiation area. We would like to check these files into slim_source gate for the time being so the install engine and DC project can proceed with their integration as planned. When the target installation project completes, all these files will be replaced with the final version produced by that project. http://cr.opensolaris.org/~ktung/target_inst/ Please provide your comments by COB next Tuesday, 10/26.
lofi.py: I think the Lofi class would be better named as a ramdisk class since that's really what is being instantiated here. This can be fixed later though .. lofi.py: 120, 132: I think the '-f' flag should be used here. target_spec.py: This file should really use instance variables for defining the target dtd fields. For example: "target" in the Target class should be an instance variable TARGET_LABEL and referred to everywhere like that. Again this isn't a bug or something it's just a future maintenance problem that might just be handled at a later point in time. target_spec.py: A ParsingError exception needs to be raised with an appropriate message instead of the currently defined funky exception. I think this should be done now. target_spec.py: 102, 140: The target schema enforces the disk_name name_type to be one of the valid types. If it isn't, we won't even get to this code. The 'else' clause on both these lines should just be removed. target_spec.py: 142, 147, 155: I don't think DiskName, DiskProp or DiskKeyword should be separate classes. Instead they should just be Disk attributes. Some of this may already be done since the time this code review was generated. target_spec.py: 287: target.dtd defines the default part_type to be "191". That's what it should be set to here. target_spec.py: 321-322: typos make this code invalid. target_spec.py: 377-378: 'action' is optional. Remove these two lines. target_spec.py: 498-499: 'action' is optional. Remove these two lines ti.py: 67-71: Remove ti.py: 144, 171: Add a comment here saying that 'create' has an implicit 'destroy' that precedes it. In addition to these files, you also need to include the packaging changes associated with these files. Alok _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
