Hi Alok,
I removed all the items where I have no further comments on.
See my response on a few items inline.
On 11/05/10 16:04, Alok Aggarwal wrote:
-----------------
usr/src/cmd/distro_const/checkpoints/create_iso.py
-----------------
- line 132: do we also need to make sure the self.volsetid that's
read from the file is not ""?
I don't see the current DC do this check and I'm not
really sure if it's needed. I mean if .volsetid is ""
then there's something really wrong in one of the other
checkpoints.
.volsetid is very important, and if it does not have the "right" value,
the image will not boot. Take a look at media-fs-root to see how
volsetid is used to determine whether a certain CD/USB is the live CD.
Current DC doesn't validate that value before it is used
seems to be an oversight.
I think we should do the check, and make sure it is not empty
and also, it is less than 128 characters. See mkisofs man page
for the 128 characters requirement.
If it is not a valid value, the image created won't boot, so, I think
it will be useful to check and abort.
- lines 72-74: why do we want to redirect stdout/stderr to NULL?
I think it is important to log all messages/errors. You can use
the exec_cmd_outputs_to_log() function in
lib/install_utils/install_utils.py.
We don't want to clutter the console with the messages from
stdout/stderr, that is why they're redirected to /dev/null.
Yes, I agree that we don't want to clutter the console with messages from
stdout/stderr. I am thinking to redirect all the stdout/stderr
from the script to the log file. That way, no information gets lost.
In the case of an error, distro_const.py will actually
print out the return code from the command as well as os.strerror() of
that return code.
Return code is useful, but all stdout/stderr from the script is even better.
---------
---------
usr/src/cmd/distro_const/checkpoints/test/test_create_usb.py
---------
- What about testing generating USB using an ISO created with
incremental option?
too hard for a small gain :)
I am thinking about not really creating the USB. Now that you are going
to pass
the name of the ISO via the DOC. It will be useful to see that code path
is working correctly.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
