Hi Drew,
I removed all the items where I have no further comments.
Just 1 question below on a couple of your responses.
On 11/08/10 07:44, Drew Fisher wrote:
Karen,
Alok wanted me to update and comment on the grub_setup.py checkpoint.
Responses inline.
- LiveCDGrubSetup.build_entries() function: What happened to all
the "special" entries that are in
the existing all_lang_slim_cd_x86.xml? Such as the livessh=enable
and all the entries to support accessibility. I checked the
dc_livecd.xml, and don't see them there either.
Added the missing ssh entries to the build_entries()
- LiveCDGrubSetup class: for the the Live CD, the accessibility
entries MUST be the last entry on the grub menu. I don't see any
special code in this class to deal with that.
Fixed along with the previous comment.
When I was talking to Alok last Friday on the phone about these 2 comments,
he mentioned that he is going to add the ssh entry and the 2 accessibility
entries into the Live CD's manifest. From your response above, it is not
clear to me whether you added them to the manifest or to the code.
Can you elaborate?
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
