Clay,
I just have a couple more comments here.
setup-dhcp.sh - 424, 508, 546 - can strip_ip_address() handle a blank
argument being passed to it, since according to the previous code,
find_network() might be returning a blank.
setup-service.sh - 73 - comment needs to be updated, we're not
checking the smf status of the service.
svc-install-server - 118 - Shouldn't we remove the AIMDNS_PID file
after we kill the process?
thanks,
-ethan
On 11/13/10 14:12, [email protected] wrote:
I caught a merge turd (in auto-install/svc/auto-installer) and a dead
comment (in setup-service.sh). New webrevs at:
http://cr.opensolaris.org/~clayb/webrev_multihomed/final_round_2/3/
http://cr.opensolaris.org/~clayb/webrev_multihomed/final_round_2/3_diff/
Thank you,
Clay
On Sat, 13 Nov 2010, [email protected] wrote:
Hi all,
We've finally got consensus on pushing the AI multihomed changes.
Below you can find the full and differential webrevs for the code
base. This code is now integrated with John Fischer's aimdns(1) code
too.
A big thanks to Ethan Quach for helping provide lots of feedback on
this code tonight and John Fischer for working with me on getting
aimdns(1) just so!
Full-webrev:
http://cr.opensolaris.org/~clayb/webrev_multihomed/final_round_2/2
Differential-webrev (from last sent out review):
http://cr.opensolaris.org/~clayb/webrev_multihomed/final_round_2/2_diff
The scenarios I've retested have been:
--------------------------------------
install server:
- Verified aimdns(1) record for each enabled subnet
- Verified AI webserver started
- Verified DHCP data printed out
- Network macro for each enabled subnet
- Service macro
* Unconfigured AI server; DHCP server; post Multihomed image; one
network
* Unconfigured AI server; not DHCP server; post Multihomed image; one
network
* AI server with a configured service adding another; DHCP server; post
Multihomed image; one network
* AI server with a configured service adding another; not DHCP server;
post Multihomed image; one network
* Unconfigured AI server; DHCP server; post Multihomed image; three
networks, one with two interfaces
* Unconfigured AI server; not DHCP server; post Multihomed image; three
networks, one with two interfaces
* Unconfigured AI server; DHCP server; pre-Multihomed image; one network
* Unconfigured AI server; DHCP server; pre-Multihomed image; three
networks, one with two interfaces (administratively disabled all but
one)
* Configured AI server; DHCP server; deleting all services
- Ensured AI webservers stopped
- Ensured AI Apache servers stopped
- Ensured aimdns(1) stopped
- Service in maintenance state
* Configured AI server; DHCP server; disable a service
- Ensured aimdns(1) record no longer published
- Ensured AI webserver stopped
* Configured AI server; DHCP server; disable last service
- Ensured AI webservers stopped
- Ensured AI Apache servers stopped
- Ensured aimdns(1) stopped
- Service in maintenance state
* Configured AI server; DHCP server; enable a service
- Ensured aimdns(1) record published
* Configured AI server; DHCP server; enable first service
- Ensured AI webserver started
- Ensured AI Apache servers started
- Ensured aimdns(1) started and record published
- Service in online state
AI client:
----------
That the client boots up and passes manifest-locator (e.g. boot image
found; zlib's found; manifest server located)
(All services were tested using automatic DHCP configuration and an X86
test client)
* Pre-multihomed image with multiple interfaces administratively
disabled to one
* Negative test (boot failed): Pre-multihomed image with multiple
interfaces
* Multihomed image with single interface
* Multihomed image with multihomed interfaces
* Multihomed image with multihomed interfaces but no mDNS record
broadcast
(must use "fallback" mechanism which is DHCP BootSrvA for X86)
Thank you,
Clay
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
