On 11/14/10 21:06, [email protected] wrote:
Hi Ethan,
Thank you for getting me these ideas! Comments below.
Thank you,
Clay
On Sun, 14 Nov 2010, Ethan Quach wrote:
Clay,
I just have a couple more comments here.
setup-dhcp.sh - 424, 508, 546 - can strip_ip_address() handle a blank
argument being passed to it, since according to the previous code,
find_network() might be returning a blank.
I'm not sure what previous code you're considering? I don't see how
$ip_start can ever be an empty string as check-server-setup.sh will
(before setup-dhcp.sh would be called) fail with the following error
for a not-plumbed network:
ad...@osai-brm-x-1:~# installadm create-service -i 0.0.0.0 -c 10 -s
/tmp/ai_x86_image.iso -n install_test_1 /var/ai/install_test_1
No configured network path to the client at 0.0.0.0 exists.
Automated Installations will not work with the current server network
setup.
Please check server network settings and try again.
Further, strip_ip_address will simply pass a blank through being just
a regex pattern. Lastly, all three blocks referenced will check if
$net is zero-length, so I'm not sure if that answers for your
envisioned case?
Its fine as long as string_ip_address() passes through a blank.
setup-service.sh - 73 - comment needs to be updated, we're not
checking the smf status of the service.
Updated to:
# we did not find a webserver PID and process
svc-install-server - 118 - Shouldn't we remove the AIMDNS_PID file
after we kill the process?
Nah, aimdns(1) cleans it up itself.
OK, that's fine.
thanks,
-ethan
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
