On 11/16/10 11:24 AM, Dave Miner wrote:
On 11/16/10 11:07 AM, [email protected] wrote:
On 11/16/10 10:44 AM, Dave Miner wrote:
I'd appreciate review of the change at
http://cr.opensolaris.org/~dminer/slim_6995479/
for
6995479 media-fs-root should consume X server interface for VESA
configuration
Thanks,
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
usr/src/cmd/slim-install/svc/media-fs-root
Suggestion:
290 x11svc=svc:/application/x11/x11-server
Defining this at the top of the file, with other constants, could make
any required future changes a bit easier.
Looks OK, other than that one suggestion.
Joe
Can you clarify why you think this would make future changes easier? I
can't think of any specific advantage.
Dave
If the service name had to change i
It might be easier to make any possible service name change if x11svc
were defined at the top of the file.
My perspective probably comes from being a long standing "C" programmer
where this type of thing would likely be defined in a header file.
I understand this is a style thing. If you've thought it over it feel it
works fine as is I'm OK with that.
Joe
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
