On 11/23/10 01:42 PM, Alok Aggarwal wrote:
Hi Keith,
On Tue, 23 Nov 2010, Keith Mitchell wrote:
[...]
install_utils.py:
set_http_proxy: If the http_proxy environment variable is already set
(e.g., the user ran something like: "HTTP_PROXY=http://example.com
distro_const build manifest.xml"), should that take precedence?
I think there are two cases here:
a) A user has HTTP_PROXY set in his environment as well as
the manifest and wants the former to be honored.
b) Same as (a) but the user wants the latter to be honored.
There doesn't seem to be a way to discern which of the two
the user desires. I think it's simplest to always allow
what's set in the manifest to take precedence.
Fair enough - I think it's fine to leave as is. (I wouldn't even have
brought it up except that my experience has been that the precedence for
similar items seems to be "Command line flag > environment variable >
value specified in file" and I wanted to know what your thoughts were)
- Keith
Thanks,
Alok
Thanks,
Keith
On 11/18/10 02:27 PM, Alok Aggarwal wrote:
Thanks to everyone who reviewed the code for the
DC->CUD project the first time around. Here's round two
that incorporates most of the changes brought up.
Incremental webrev against the initial webrev:
http://cr.opensolaris.org/~aalok/cud_dc-diff2/
Complete webrev:
http://cr.opensolaris.org/~aalok/cud_dc-2/
Some of the most significant changes included here
are:
- DC Logging has been overhauled. logger's transfer_log()
was enhanced as part of CR 7000990 and DC now uses that
instead of managing log files, etc by itself.
- Determining the ZFS mountpoints: This code was reworked
to utilize the zfs code in install_target. The mountpoints
are now determined *after* TI has executed instead of trying
to determine mountpoints ahead of time.
- DC Lockfile: This is now a context manager (used via the
"with" statement) and has added additional streamlining
- Unittests: There are now unittests for the primary DC
application. Coverage is ~ 70%
- A SimpleSchemaElement class has been defined for use by
.. well, simple schema elements. This code will eventually
be moved to the DOC code (there's an outstanding bug on this).
- kwargs/args in execution_checkpoint.py is now a separate class
- Sort files are now included in the source
- Manifest Parser tests that were commented out due to the absence
of DC in slim_source have been uncommented.
Please take a look and provide your feedback by COB, December 1.
Thanks,
Drew and Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
