Just a quick reminder to everyone intending to do a second pass through, the deadline for providing review comments is COB, December 1st.
If you intend on reviewing and need more time, please let me know as well. Alok On Thu, 18 Nov 2010, Alok Aggarwal wrote:
Thanks to everyone who reviewed the code for the DC->CUD project the first time around. Here's round two that incorporates most of the changes brought up. Incremental webrev against the initial webrev: http://cr.opensolaris.org/~aalok/cud_dc-diff2/ Complete webrev: http://cr.opensolaris.org/~aalok/cud_dc-2/ Some of the most significant changes included here are: - DC Logging has been overhauled. logger's transfer_log() was enhanced as part of CR 7000990 and DC now uses that instead of managing log files, etc by itself. - Determining the ZFS mountpoints: This code was reworked to utilize the zfs code in install_target. The mountpoints are now determined *after* TI has executed instead of trying to determine mountpoints ahead of time. - DC Lockfile: This is now a context manager (used via the "with" statement) and has added additional streamlining - Unittests: There are now unittests for the primary DC application. Coverage is ~ 70% - A SimpleSchemaElement class has been defined for use by .. well, simple schema elements. This code will eventually be moved to the DOC code (there's an outstanding bug on this). - kwargs/args in execution_checkpoint.py is now a separate class - Sort files are now included in the source - Manifest Parser tests that were commented out due to the absence of DC in slim_source have been uncommented. Please take a look and provide your feedback by COB, December 1. Thanks, Drew and Alok
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
