Hi Drew.
Looks good modulo the other's comments, and one nit:
install_target/ti.py: 114:
Adding the third arg of None doesn't do anything, since the third arg
defaults to None anyway. (I'm looking at install_target/zpool.py for
this.) How come this line was changed? How come line 117 wasn't
changed as well, as the two lines are now inconsistent with each other
in this respect?
Thanks,
Jack
On 12/14/10 10:01 AM, Drew Fisher wrote:
Could I please get a code review for:
7006443 transfer-ips-install checkpoint created image in wrong location
Bug:
http://monaco.sfbay.sun.com/detail.jsf?cr=7006443
Webrev:
http://cr.opensolaris.org/~drewfish/dc_7006443/
The way DC handled mountpoints of ZFS datasets and zpools was very
wrong. It made an assumption that everything would mount at "/".
Tests run:
- Create a new zpool and a new zfs dataset both with no mountpoint
information (zpool mounts at /, dataset mounts at
/zpool_name/dataset_name)
- Create a new zpool with an explicit mountpoint defined and a new zfs
dataset with no mountpoint information (zpool mounts at /mountpoint,
dataset mounts at /mountpoint/dataset_name *with the name of the zpool
stripped from the dataset_name* - this is how ZFS currently works)
- Use an existing zpool, but explicitly set the mountpoint of the zfs
dataset to something outside of the mountpoint of the pool.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
