On 12/14/10 12:35 PM, Alok Aggarwal wrote:
Hi Drew,
On Tue, 14 Dec 2010, Drew Fisher wrote:
Could I please get a code review for:
7006443 transfer-ips-install checkpoint created image in wrong location
Bug:
http://monaco.sfbay.sun.com/detail.jsf?cr=7006443
Webrev:
http://cr.opensolaris.org/~drewfish/dc_7006443/
target_spec.py: 408 - 419: Should this be of the form:
try:
test_dataset = ..
test_dataset_mp = ..
filesystem.mountpoint = ..
except AttributeError:
continue
i.e, simply remove that else clause on 413 and move it up.
Whoops. Fixed.
target_spec.py: 432: I think we should be setting the
mountpoint to 'None' if one wasn't specified instead
of '/'. If no mountpoint was specified, just let ZFS
pick the default.
Done.
target_spec.py: 439: Since the mountpoint is optional
in the DTD, this should be set only when it's not None.
Done.
init.py: 337-341: If the mountpoint for the zpool isn't
specified, we should just not set it. Let ZFS pick one.
Done.
ti.py: 105, 123, 405, 423: These checks need to change
as well to check for 'None' instead.
Done. I couldn't find lines 405 or 423 though. Do you remember what
you were looking at?
Thanks, Alok!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
