Hi Clay,
Looks fine to me.
Alok
On Mon, 27 Dec 2010, [email protected] wrote:
Hi all,
Could someone verify that all's well in my fix for CR 7009206 - "sh:
line 1: /usr/bin/[: not found" seen during installadm create-service?
Evaluation and rationale:
The bug was caused by my use of /usr/bin/[ (part of pkg:/file/gnu-coreutils)
instead of /usr/bin/test (part of pkg:/SUNWcs). I've verified that the
changed code does what is expected and have left the original style in tact,
as the current string '"/usr/bin/test `%s -c 'source[...]' I feel is more
telling of what is going on, rather than shucking /usr/bin/test off to
installadm.h (since it something-help-us-all should not be reused here before
installadm(1) is Python-ized) and using a string like "%s '%s -c
'source[...]'.
The change is at:
http://cr.opensolaris.org/~clayb/7009206
Thank you,
Clay
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
