okay...it LGTM
-Sanjay
On 12/27/10 05:44 PM, [email protected] wrote:
Hi Sanjay,
I didn't see anything from hg pbchk for the "C style check:"
heading, however, running with the picky, verbose option (-pv) to
/opt/onbld/bin/cstyle, I see that I pushed over 80 characters and
there were some trailing spaces on comments:
354: space or tab at end of line
354: improper first line of block comment
526: improper block comment
526: indent by spaces instead of tabs
540: line > 80 characters
680: space or tab at end of line
I've addressed all these and the back-to-back comments on lines 537,
538. I'll repush if the following looks okay?
http://cr.opensolaris.org/~clayb/7009206/webrev2
Thank you,
Clay
On Mon, 27 Dec 2010, sanjay nadkarni wrote:
On 12/27/10 04:51 PM, [email protected] wrote:
Hi all,
Could someone verify that all's well in my fix for CR 7009206 -
"sh: line 1: /usr/bin/[: not found" seen during installadm
create-service?
Evaluation and rationale:
The bug was caused by my use of /usr/bin/[ (part of
pkg:/file/gnu-coreutils) instead of /usr/bin/test (part of
pkg:/SUNWcs). I've verified that the changed code does what is
expected and have left the original style in tact, as the current
string '"/usr/bin/test `%s -c 'source[...]' I feel is more telling
of what is going on, rather than shucking /usr/bin/test off to
installadm.h (since it something-help-us-all should not be reused
here before installadm(1) is Python-ized) and using a string like
"%s '%s -c 'source[...]'.
The change is at:
http://cr.opensolaris.org/~clayb/7009206
Thank you,
Clay
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Has the code been through cstyle ? A quick look at the the comments 2
/* */back to back, makes me think not.
-Sanjay
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
