On 12/29/10 06:28 PM, Keith Mitchell wrote:
Hi Jack,
Responding to the rest of the review (and adding a few additional
comments to Jan's responses). See below.
- Keith
On 12/29/10 08:25 AM, Jan Damborsky wrote:
Hi Jack,
thank you very much for review.
Let me address some of your comments - please see my response in line.
I will let Keith respond to the rest of them.
Keith, feel free to let me know if I skipped something which
I should address.
Thank you,
Jan
On 12/28/10 07:21 PM, Jack Schwartz wrote:
Hi Jan and Keith.
I reviewed section (B) sysconfig module - mapping data in DOC & smf
profile generator. Here are my comments:
[...]
usr/src/cmd/system-config/profile/user_info.py
----------------------------------------------
64: Usernames have restrictions. From passwd(4):
"string of no more than eight bytes consisting of characters from
the set of alphabetic characters, numeric characters, period (.),
underscore (_), and hyphen (-). The first character should be
alphabetic and the field should contain at least one lower case
alphabetic character.
user name is actually validated sooner - when user configures it on
User screen:
http://cr.opensolaris.org/~kemitche/sci.1/usr/src/cmd/system-config/users.py.html
(see function validate())
is_username_valid() in user_info.py is consumed by to_xml() to determine
if portion of SC manifest configuring user account should be
generated or not
(when user account was not created on User screen).
We should perhaps use different name for that function - do you think
that
something like is_username_configured() might be better ?
To add to this, it wouldn't be a bad idea to consider moving the core
of the above mentioned "validate()" function into UserInfo; the Text
Installer does tend to do more validation in the UI than it really
should.
I agree it makes sense to have validate() implemented as a method of
UserInfo class.
I will move that function accordingly.
127: I would prefer to see the shell passed in from somewhere else
(maybe a place where there are other default definitions?) as
opposed to it being hardwired. Suppose it gets changed in the future?
That is a good suggestion. I will initialize it in __init__().
Along those same lines, perhaps the sudoers permissions, homedir, and
"roles" should be set during __init__ as well (and perhaps roles and
sudoers should NOT default to being permissive; but rather, be set by
the application).
Sounds reasonable. I will change that.
WRT homedir, it is not currently configured by SCI tool. Instead,
SCI tool delegates that task to install/config smf method which is eligible
to construct the desired default value (/export/home/<login>).
Jan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
