On 01/ 3/11 06:47 PM, Karen Tung wrote:
Hi Jan,
I have no further comment on your other responses.
Just want to follow up with this one, in case you are looking
for a response..
On 12/31/10 01:43 AM, Jan Damborsky wrote:
> usr/src/lib/libict/ict_test.c
- line 114, line 125: I know you are just following the convention
in this file.
Is there a reason why a hard coded number is used as the 3rd
argument to
the strncmp() function instead of doing strlen(SET_NODENAME) and
strlen(SET_HOSTS)? Using strlen() seems more maintainable.
Yep. Following existing convention was the only reason for using hard
wired numbers instead
of strlen(). I actually considered going with sizeof(), as those are
arrays with constant length,
but at the end I preferred consistency over maintainability, since
that code is going to disappear
anyway as a result of new ICT effort Ginnie is involved in.
However, if you would prefer to have it changed, I can certainly do
that. Please let me know.
I am OK with using the hard coded number just so that it is consistent
with rest
of the function, since this code will be removed shortly.
ok.
Thank you for review, Karen.
Jan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
