Dave, responding to your logging comments below.
On 01/12/11 09:51 PM, Dave Miner wrote:
On 12/21/10 11:32 AM, William Schumann wrote:
Requesting code review for enhancements for service configuration
profiles in the Automated Installer.
http://cr.opensolaris.org/~wmsch/profile/
...
45, 46, others: I'm skeptical of having our own log rotation going on here. logadm is the general facility in Solaris for
administrators to control log rotation and I'd prefer to see that used since it provides a way for them to express their preferred
policy, which doesn't seem to be supported here. Also, I'm somewhat surprised that this isn't using InstallLogger, but perhaps
there's a reason that's not suitable somehow?
The InstallLogger class from solaris_install/logger.py was written for the install environment on the install target, and not the
installadm UI nor an AI server CGI (e.g., logfile is hard-coded for /var/tmp, formatting method seems to be intended only for the
Transfer phase logging, hardcoded formatter, etc.).
However, logger.py does seem to be a more appropriate place for new AI
server-side logging code than common_profile.py.
To substitute logadm for the RotatingFileHandler, I think it could be
accomplished like this:
- if an /etc/logsvc.conf record for installadm logfile did not exist, installadm would append one, leveraging fmadm(1M) with some
defaults
- replace RotatingFileHandler with a non-rotating logging handler like logger.py's FileHandler, which is a class derived from the
Python logging.FileHandler class (needs some exception handling for failure to create log directory or log file)
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
