On 01/26/11 08:51 AM, William Schumann wrote:
Dave,
I implemented all of your recommendations, except the ones we discussed
on caiman-discuss.
Resubmitting for review at http://cr.opensolaris.org/~wmsch/profile2/
Generally looks quite good, just a few relatively minor issues.
common_profile.py, 207: s/registed/registered/
create_profile.py
126: why not just package /var/ai/profiles and rip out 11 lines here?
locate_profile.py
138-140: Test code that needs to be removed/replaced?
set_criteria.py
87: Perhaps add a "not both" to the end here to clarify slightly
(though, I wonder, would it be possible and useful to be able to do both
at once? seems convenient.)
ict.py
2377: /etc/svc/profile/site is a packaged directory, no need to create.
installadm.1m.txt
84,907: should be smf(5)
916: 2011
install-installadm.mf: I don't see where locate_profile is packaged?
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
