Drew, just a few suggestions on the comments:
A general suggestion is that there's inconsistent use of 'quoting' when
referring to element and attribute names. It would be better to have a
consistent rule used throughout.
28 <!--
29 in_zpool and in_vdev are reference attributes to a
30 corresponding <zpool> name and <vdev> name under the <logical>
31 element. This is how physical elements are linked with logical
32 entires.
s/entires/entries/
67 <!--
68 Partition and Slice names are numeric values, e.g. 1, will be
69 interpreted as partition 1 or slice 1.
70 -->
71 <!--
72 No size specification means we create the slice or partition with
73 a size value set to the size of parent element.
74 -->
75 <!--
76 The name attribute may only be omitted if action is
77 "use_existing_solaris2", in which case there must already be a
78 Solaris2 partition on the disk and this partition will be
selected.
79 In addition, if the action is "use_existing_solaris2", both
the name
80 and part_type attributes are ignored when selecting a partition.
81 -->
Any particular reason not to combine the above into a single block comment?
120 <!--
121 The 'val' attribute of Size must be suffixed with a size unit.
122 e.g. 100gb, 2secs, 2tb.
123 -->
s/Size/size/
128 <!--
129 ISCSI does not have an action attribute. We use iscsi devices but
130 we do not operate directly on them.
131 -->
s/ISCSI/iscsi/ (as it's referring to the element)
s/iscsi/iSCSI/ (as it's referring to the technology)
144 <!--
145 If zpools and/or vdev are specified, then they must be associated
146 with disk_names, partitions or slices via the use of the in_zpool
147 and/or in_vdev attributes of those elements, described above.
148 -->
Suggest "zpools and/or vdevs" for parallel plurality.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
