On 01/26/11 05:19 AM, Dermot McCluskey wrote:
Drew,
Comments in-line below.
1 <!--
2 CDDL HEADER START
3
4 The contents of this file are subject to the terms of the
5 Common Development and Distribution License (the "License").
6 You may not use this file except in compliance with the License.
7
8 You can obtain a copy of the license at
usr/src/OPENSOLARIS.LICENSE
9 or http://www.opensolaris.org/os/licensing.
10 See the License for the specific language governing permissions
11 and limitations under the License.
12
13 When distributing Covered Code, include this CDDL HEADER in each
14 file and include the License file at usr/src/OPENSOLARIS.LICENSE.
15 If applicable, add the following below this CDDL HEADER, with the
16 fields enclosed by brackets "[]" replaced with your own
identifying
17 information: Portions Copyright [yyyy] [name of copyright owner]
18
19 CDDL HEADER END
20
21 Copyright (c) 2011, Oracle and/or its affiliates. All rights
reserved.
Nit: shouldn't this be "Copyright (c) 2010, 2011, Oracle ..." ?
22
23 -->
24
25 <!ELEMENT target (disk+, logical*)>
Sorry not to mention this earlier, but I have another question:
Is it possible that the user might want to the write a manifest
where they don't specify *any* details of specific disks or zpools,
but only want to say that there should be no swap or no dump
used? ie:
<target>
<logical noswap="true" nodump="true"/>
</target>
If this is a legitimate thing we want to allow the user to specify,
then we would need to change "disk+" to "disk*". However, I don't
like doing this as it might lead the user to think they can specify
<logical> without specifying and <disk>s, which would be a
semantic error.
This should never be allowed.
-sanjay
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
