Since bootfs is a property of the pool, and not the dataset, I'm inclined to say it should stay the way it is. Particularly since during validation we want to make sure there's only 1 root *pool*. Consider the slice selection screen of the Text Installer, wherein we need to verify that the user has created one and only one root pool to install into - at that stage, we don't even really *have* datasets.

- Keith

On 02/ 1/11 03:48 PM, Alok Aggarwal wrote:
The is_root flag in the target_schema corresponds to the
'bootfs' pool property. That is, 'is_root' tells TI
what to set 'bootfs' to.

Currently the is_root flag is set at the zpool level
in the schema. Looking at zpool(1M), the bootfs property
contains a value like this:

bootfs=pool/dataset

That implies that is_root really must be set at the 'filesystem' level in the schema:

@@ -149,7 +149,6 @@
<!ELEMENT zpool (vdev*, filesystem*, zvol*, pool_options?, dataset_options?,
 be*)>
<!ATTLIST zpool name CDATA #REQUIRED>
<!ATTLIST zpool action (create|delete|preserve|use_existing) "create">
-<!ATTLIST zpool is_root (true|false) "false">
<!ATTLIST zpool mountpoint CDATA #IMPLIED>

<!--
 @@ -176,6 +175,7 @@
<!ELEMENT filesystem (options?)>
<!ATTLIST filesystem name CDATA #REQUIRED>
<!ATTLIST filesystem action (create|delete|preserve) "create">
+<!ATTLIST filesystem is_root (true|false) "false">
<!ATTLIST filesystem mountpoint CDATA #IMPLIED>

Does this change seem reasonable?

Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to