On Tue, 1 Feb 2011, Keith Mitchell wrote:

On 02/ 1/11 04:14 PM, Alok Aggarwal wrote:

On Tue, 1 Feb 2011, Keith Mitchell wrote:

Since bootfs is a property of the pool, and not the dataset, I'm inclined to say it should stay the way it is. Particularly since during validation we

bootfs is a pool property but it needs to be set to
a *dataset*.If you set it (is_root really) as an attribute of 'zpool', then there's no way of telling which dataset
should the bootfs property be set to. And, that seems like
a deficiency.

Perhaps the deficiency, then, is in having a "true|false" value?

Possibly. It could be changed to have the name of the
dataset as a value but I could see that being a problem
in the example below where the user isn't laying out
custom datasets.

want to make sure there's only 1 root *pool*. Consider the slice selection screen of the Text Installer, wherein we need to verify that the user has created one and only one root pool to install into - at that stage, we don't even really *have* datasets.

To validate that there exists only one root pool, TI/TD
would ensure that 'is_root' is set only on a single filesystem
system wide.

The Text Installer was a bad example, as the in-DOC representation isn't tied to the DTD the way an AI xml manifest will be. However, suppose you have an AI manifest that doesn't explicitly layout any datasets, but does create multiple pools - how would the end user indicate which is the root pool at that point?

That's good point. Maybe we need is_root be an attribute
of both the zpool element as well as the filesystem element.

So, if a user doesn't explicitly layout datasets but sets
is_root on a given pool, AI internally will set the is_root
attribute on the ROOT dataset.

Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to