Hi John,
A few questions:
In ai_get_manifest.py, the signature for ai_get_http_file has *nv_pairs.
Based on the usage, that should simply be "nv_pairs" without the
asterisk (and the code below should replace "nv_pairs[0]" with "nv_pairs").
ai_get_requested_criteria_list: The comment on lines 730-745 should
probably be moved up to this function instead, to be more clear. Beyond
that, what if the criteria file was hand-edited by an admin and has
extra spaces, e.g., <Criteria Name="abc" />? (Or is the XML
normalized at some point before this?) Additionally, the docstring
mentions that it returns 0 for success, and -1 for failure, but the
function never directly returns either of those. (probably best to just
return the required_criteria list and omit the return value)
753-755: ai_criteria_known is not defined in this scope - should this be
"known_criteria"?
752 - 758: Pythonization suggestion:
for criteria in criteria_required:
if known_criteria.get(criteria, None):
ai_crit_response[criteria] = known_criteria[criteria]
- Keith
On 02/ 3/11 10:05 AM, John Fischer wrote:
All and Sue (specifically for the AI_database change),
After I delivered the AI webserver design project Mary found that the
new ISOs could
not get a manifest from build 157 and 158 cherrypy webservers. The
failure was because
a new bug fix went into the AI_database.py code that was not anticipated.
The webrev is located at:
http://cr.opensolaris.org/~johnfisc/7016997-get-manifest/
The solution is 2 fold. First, the database criteria list needs to be
checked within the
findManifest() function prior to it being used. Secondly, the
ai_get_manifest.py compatibility
code needs to be enhanced to do the handshaking it used to do prior to
the protocol
changes. Essentially, the compatibility re-introduces the handshake
code.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
