On 02/ 7/11 06:56 AM, Dermot McCluskey wrote:
Dave,
Looks generally fine to me. I just note the following
very minor points:
usr/src/cmd/distro_const/manifest/boot_archive_contents_sparc.xml:
60<name>usr/sbin/modload</name>
61<name>usr/sbin/sparcv9/modload</name>
62<name>usr/sbin/mount</name>
63<name>usr/sbin/pmadm</name>
64<name>usr/sbin/prtconf</name>
65<name>usr/sbin/sparcv9/prtconf</name>
If, as it appears, you are sorting this file alphabetically, line 61
should be moved down.
It's alphabetical, except that I believe it's better for
architecture-specific variants to be grouped next to the main entry to
minimize the likelihood of mistakenly missing one when making changes,
so I'd prefer to leave it here.
usr/src/cmd/distro_const/profile/generic.xml:
190<service name='system/filesystem/usr' version='1' type='service'>
191<instance name='default' enabled='true'/>
192<exec_method
193 type='method'
194 name='start'
195 timeout_seconds='0'
196 exec=':true'/>
197</service>
In most other cases, exec_method is a sub-element of instance. Here, it
isn't but is indented to make it appear as if it is. Either un-indent
exec_method or make it a sub-element of instance?
Sure, will undent it.
Dave
- Dermot
On 02/04/11 20:41, Dave Miner wrote:
Caimaniacs, I'd appreciate review of the webrev at:
http://cr.opensolaris.org/~dminer/slim_boot_review/
which addresses the following bugs:
1351 combine listcd and listusb.
11244 devprop(1M) could be used to obtain x86 install options instead
of parsing prtconf(1M) output
6978168 Occasional build failures in test_td
7003563 system/install/gui-install has incorrect classification
6105 Need to rework live-sysidtool.xml
12819 live-fs-root: should use $COMMAND_NAME instead of hard coded paths
16413 net-fs-root should mount both .zlibs explicitly read-only
7010075 Missing /usr/sbin/kfbdaemon in sparc miniroot for snv_155.
7012600 method calculate_size() within PrePkgImgMod class trucates on
open the .image_info file
7010834 boot_archive_configure should not use coreadm.conf to set core
settings
Thanks,
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
