Hi Dave,
Everything looks good to me now.
Thanks,
--Karen
On 02/07/11 14:24, Dave Miner wrote:
On 02/ 7/11 12:15 PM, Karen Tung wrote:
Hi Dave,
Everything looks good in general. I have a few minor comments.
usr/src/cmd/distro_const/profile/generic.xml:
lines 191-197: This block seems to be missing the closing</instance>
tag like the other
instance name definitions. Perhaps it is OK because you already have
the closing "/"
at line 191? It just looks odd to me since all other instance
definitions
have the explicit closing</instance> tag.
Dermot pointed out as well; normalized.
usr/src/cmd/slim-install/svc/media-assembly
- line 85: Remove XXX from comment?
- line 87: check return value from the mount command?
- line 107: Since you are doing major update to this file, I think it
would make
the code cleaner to move this line closer to where the value of
$assistive_tech is checked.
usr/src/cmd/slim-install/svc/net-assembly
- line 317: remove XXX from comments?
- line 319: check return value of mount command?
Above all accepted. Also noted some other cleanup of error messages
and common definitions between media-assembly and net-assembly and
took care of that.
Webrev updated in place.
Thanks,
Dave
Thanks,
--Karen
On 02/ 4/11 12:41 PM, Dave Miner wrote:
Caimaniacs, I'd appreciate review of the webrev at:
http://cr.opensolaris.org/~dminer/slim_boot_review/
which addresses the following bugs:
1351 combine listcd and listusb.
11244 devprop(1M) could be used to obtain x86 install options instead
of parsing prtconf(1M) output
6978168 Occasional build failures in test_td
7003563 system/install/gui-install has incorrect classification
6105 Need to rework live-sysidtool.xml
12819 live-fs-root: should use $COMMAND_NAME instead of hard coded
paths
16413 net-fs-root should mount both .zlibs explicitly read-only
7010075 Missing /usr/sbin/kfbdaemon in sparc miniroot for snv_155.
7012600 method calculate_size() within PrePkgImgMod class trucates on
open the .image_info file
7010834 boot_archive_configure should not use coreadm.conf to set core
settings
Thanks,
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
