Sue,
Thanks for the review.
I have updated the review as suggested. The new review is located
at:
http://cr.opensolaris.org/~johnfisc/name-length-3/
http://cr.opensolaris.org/~johnfisc/name-length-diff-3/
This should address all current issues.
Thanks,
John
On 02/ 7/11 05:26 PM, Sue Sohn wrote:
Hi John,
installadm_util.c
45-46 Please update comment to indicate you are also checking for
length of service name.
installadm.1m.txt
193-194 Suggested reword (or something similar):
"the previous non-named service was 10"
->
"the previous number that installadm selected for an install service
is 10"
764 - Please update date at end of file
Sue
On 02/ 7/11 09:51 AM, John Fischer wrote:
All,
I have updated the webrev to include the installadm man page.
The new webrev is located at:
http://cr.opensolaris.org/~johnfisc/name-length-2/
http://cr.opensolaris.org/~johnfisc/name-length-diff-2/
Just in case anyone looked at it already.
Thanks,
John
On 02/ 4/11 05:20 PM, John Fischer wrote:
All,
During the AI webserver project QE also identified that there is a
limit on the
length for AI service names. CR 4508 and 7014147 document the failure:
http://defect.opensolaris.org/bz/show_bug.cgi?id=4508
http://monaco.sfbay.sun.com/detail.jsf?cr=7014147
The webrev is located at:
http://cr.opensolaris.org/~johnfisc/name-length/
The main limit is based upon mDNS. From the dns-sd man page:
name can be any arbitrary unicode text, containing any
legal unicode characters (including dots, spaces,
slashes, colons, and so on without any restrictions), up
to 63 UTF-8 bytes long.
Thus the strlen() > 63 check within the validate_service_name().
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
