Keith,
Looks good aside from one small nit:
__init__.py: 276 - use "is not" instead of "!=" as you do above on 269/272.
Thanks for addressing this for me!
-Drew
On 2/21/11 1:51 PM, Keith Mitchell wrote:
Hi all,
Can I get a review of my fixes for:
7020660 Change solaris_install.Popen() from a class to a function
7020658 solaris_install.Popen shouldn't always raise an exception if
stderr is populated
Webrev:
http://cr.opensolaris.org/~kemitche/webrev.7020660/
Please ignore the commit message; I will be combining this changeset
with my previous set of Popen fixes and pushing once review completes.
Thanks,
Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
