I agree, I'll remove those lines.
- Keith
On 02/22/11 01:21 PM, Evan Layton wrote:
Hi Keith,
Minor nit, in __init__.py are line 223 and 224 really needed or could
we just change 226 to something more like
"solaris_install.Popen.check_call provides added functionality that
will store...". It just seems that having both lines 223 and 226 is a
bit redundant.
223 solaris_install.Popen.check_call also provides additional
functionality
224 (see below)
225
226 solaris_install.Popen.check_call will store the output
from stdout and
227 stderr if they are set to Popen.STORE. Note that
228 Popen.stdout and Popen.stderr are replaced with a string -
229 references to filehandles won't be preserved in the
manner that a
230 standard use of the Popen class allows.
Other than is very minor nit the changes look good to me.
Thanks,
-evan
On 2/21/11 1:51 PM, Keith Mitchell wrote:
Hi all,
Can I get a review of my fixes for:
7020660 Change solaris_install.Popen() from a class to a function
7020658 solaris_install.Popen shouldn't always raise an exception if
stderr is
populated
Webrev:
http://cr.opensolaris.org/~kemitche/webrev.7020660/
Please ignore the commit message; I will be combining this changeset
with my
previous set of Popen fixes and pushing once review completes.
Thanks,
Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
