Thanks Evan.
John
On 02/22/11 12:51 PM, Evan Layton wrote:
Looks fine to me.
(Gee that was a tough review ;)
-evan
On 2/22/11 12:29 PM, John Fischer wrote:
All,
Additional test environment shows that aimds_mod.py ends up in an
infinite loop in
browse mode. A new webrev is located at:
http://cr.opensolaris.org/~johnfisc/7018241-aimdns-infinite-loop/
The CR is located at:
http://monaco.sfbay/detail.jsf?cr=7018241
Or:
http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7018241
The failure is do to the fact that self.count is set to 0. Thus the
check at line
411 (if count == self.count) fails because at line 410 count is
incremented.
The fix is to simply check for greater then or equal to.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
