Ethan,
I'll pass on exception too.
John
On 02/22/11 01:36 PM, Ethan Quach wrote:
On 02/22/11 13:31, John Fischer wrote:
Ethan,
With the >= switch this actually isn't needed. I'll remove it.
Hmm, so then is line 809 needed?
-ethan
John
On 02/22/11 01:17 PM, Ethan Quach wrote:
John,
The changes look ok, but just one question/nit:
811-813 - Can you add a comment why this needs to be added here.
(Also, is there a reason why that similar change isn't needed in
find()?)
-ethan
On 02/22/11 11:29, John Fischer wrote:
All,
Additional test environment shows that aimds_mod.py ends up in an
infinite loop in
browse mode. A new webrev is located at:
http://cr.opensolaris.org/~johnfisc/7018241-aimdns-infinite-loop/
The CR is located at:
http://monaco.sfbay/detail.jsf?cr=7018241
Or:
http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7018241
The failure is do to the fact that self.count is set to 0. Thus
the check at line
411 (if count == self.count) fails because at line 410 count is
incremented.
The fix is to simply check for greater then or equal to.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
