Yes, that was what Evan had mentioned, which I had forgotten to run for this change.
I'm thinking that in addition to this check, if, for example hg commit can automatically update the copyright and whatever standard entry found in python, shell, c, or java codes, it'd be nice. I think Keith mentioned something in a separate email about hg capability to do this, but I haven't looked at that in detail yet. Thanks, Martin -----Original Message----- From: Evan Layton <[email protected]> To: Dave Miner <[email protected]> Cc: Martin Widjaja <[email protected]>, [email protected] Sent: Wed, 23 Feb 2011 4:14 PM Subject: Re: [caiman-discuss] Webrev for logger fixes On 2/23/11 3:31 PM, Dave Miner wrote: > On 02/23/11 05:22 PM, Martin Widjaja wrote: >> Thanks Karen. >> Had a separate conversation with Evan. I guess it'd be nice if hg can do >> this automagically. Maybe there's a macro or something that can be >> defined for hg to do such things? Not sure... just that it'd be nice. >> webrev is updated. >> > > In case nobody has already mentioned this, "hg nits" will check these things > for > you. Integrations are expected to be nit-free, so best to run it before > generating the webrev. The hg nits stuff is part of what Martin and I had talked about. I would suggest using not only hg nits but hg outgoing -vp (to check what you would be pushing) as well before doing your webrev. -evan
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
