Sue - In reviewing this quickly, it looks good overall, but I have several questions, mostly to satisfy my own curiosity:
- Makefile: would it be worth keeping the generic rules for building .c, etc.? Maybe this can be useful for other things later on? - installadm.py: 354: is there a reason to remove the traceback limit here? Is this going to be too much if everything is printed? - installadm_common.py: 95-105: is this ksh execution to determine multi-home going to persist or is there a better way to gather this information using either python lib or C lib? I am personally not a fan of command line output parsing. - libaiscf.py: 105: what's wrong with previous implementation? Thanks, Martin PS. test_ai_smf_service.py: can't get more optimistic than wobbly knees and failing eyesight.. On 2/28/2011 11:44 AM, Sue Sohn wrote:
Please do a code review of the changes for: 7020631 Convert create-service.c to python http://monaco.sfbay.sun.com/detail.jsf?cr=7020631 Webrev: http://cr.opensolaris.org/~sohn/7020631 Thanks, Sue _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
