Hi -
Here is a review for e. I saw that Keith reviewed a, so I'll defer it.
I mostly saw that copyrights need to be updated.
thanks,
ginnie
Makefile.master
--------------------
line 23 - copyright needs updating.
line 114 - since we're alphabetizing, this should go before libbe
--------------------
Targetdirs - ok
-------------------
dc/__init__.py
-------------------
ok.
dc_livecd.py
-----------------
line 115 - you need to change the repo back to pkg.oracle...
line 163 - same comment
lib/Makefile.lib
------------
line 22 - update copyright
lib/Makefile.targ
--------------------
line 23 - update copyright
line 130 - move before TARGETLIBBE
line 182 - same comment as for line 130
engine/__init__.py
------------------------
update copyright
test_mp_w_engine.py
---------------------------
update copyright
test_mp_without_engine.py
-----------------------------------
copyright
test_mw_dry_run.py
---------------------------
copyright
test_mw_with_engine.py
-------------------------------
copyright
test_mw_without_engine.py
------------------------------------
copyright
install_target/Makefile
---------------------------
Fix copyright
line 30 - fix tabbing
errsvc.py and test_liberrsvc.py
------------------
copyright update
On 02/24/11 01:33 PM, Alok Aggarwal wrote:
We would like volunteers to review the TI/TD project. The
review is being broken down into the following chunks to
aid the review process.
a) Target discovery
b) Target Instantiation
c) Target controller API and target validation
d) ctypes interfaces
e) Other
Webrev location:
http://cr.opensolaris.org/~aalok/cud_ti/
Please let us know which of the above sections you'd like to
sign up for, an approximate list of files corresponding to each of the
review sections is included below for your convenience.
We would like your comments back by March 10.
Thanks,
Drew, Alok (and Jean)
(a) usr/src/lib/install_target/td.py
usr/src/lib/install_target/test_td.py
usr/src/lib/install_target/vdevs.py
usr/src/lib/install_target/size.py
usr/src/lib/install_target/test/test_zpool_vdevs.py
b) usr/src/lib/install_target/ti.py
usr/src/lib/install_target/physical.py
usr/src/lib/install_target/logical.py
usr/src/lib/install_target/test/test_target_instantiation.py
usr/src/lib/install_target/test/ti_full.py
c) usr/src/lib/install_target/shadow/*
usr/src/lib/install_target/test/test_shadow_list.py
d) usr/src/lib/install_target/libadm/*
usr/src/lib/install_target/libbe/*
usr/src/lib/install_target/libdevinfo/*
usr/src/lib/install_target/libdiskmgt/*
usr/src/lib/install_target/libnvpair/*
e) Makefiles, DC changes, MP test changes, engine and
errorsvc changes, packaging
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
