Hi Drew.
I'm fine with your responses at this point; I'll wait for the second
round of code review to give a thumbs up for the items I left in my
reply below.
Thanks,
Jack
On 03/17/11 01:11 PM, Drew Fisher wrote:
You could sort self._children on child.start_sector and get rid of the
V_BACKUP child, then check the "child" pairs for overlap easily.
Additionally you can get rid of the usage list entirely, which would
simplify the loop at 255-267. In fact, the 241-246 and 255-267
loops could probably be combined and simplified together.
The get_gaps() methods have been rewritten a few times now (with
another iteration to come). Take a look when we send out the second
round of code.
243: Is there such a thing as a backup partition? (I know about a
backup slice.)
No there's not.
Thanks, Jack!
You're welcome.
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
