John,
Thanks for the comments...
On 03/31/11 19:42, John Fischer wrote:
Ethan,
Nice clean up work on the svc-install-server script.
A comment and a question below.
Thanks,
John
================================================================================
usr/src/cmd/installadm/create_client.py
================================================================================
1. Instead of:
335 if not (PROP_STATUS in service_props.keys()):
Please use:
if PROP_STATUS not in service_props:
Sure, I can make this change. (I was only copying what I saw in
ai_smf_service.py ...)
================================================================================
/usr/src/cmd/installadm/svc-install-server
================================================================================
1. When would the work_files exist prior to the
setup_compatibility_ports and
setup_main_ports functions (i.e., is this check necessary)?
I think I originally was using a file called ${COMPATIBILITY_PORTS}.new,
and so kept the check. But now that its changed to tmp located, pid
based file, it can be removed. I'll remove those two chunks.
thanks for the review,
-ethan
76 typeset work_file="/system/volatile/$(basename
${COMPATIBILITY_PORTS}).$$"
77
78 # If work_file exists, remove it.
79 if [ -f ${work_file} ] ; then
80 ${RM} ${work_file}
81 fi
148 typeset work_file="/system/volatile/$(basename
${LISTEN_ADDRESSES}).$$"
149
150 # If new work file exists, remove it.
151 if [ -f ${work_file} ] ; then
152 ${RM} ${work_file}
153 fi
================================================================================
On 03/31/11 05:53 PM, Ethan Quach wrote:
All,
Can I please get a review for the following bugfix:
Webrev:
----------
http://cr.opensolaris.org/~equach/webrev.7031357/
Testing:
---------
1. Made sure create-client does not do anything wrt enablement of the
service regardless of its state.
2. Made sure create-client prints out a warning if the service is
disabled.
3. Made sure the 'refresh' method does not restart apache if neither
of the included Listen files are changed.
4. Made sure the 'refresh' method does restart apache if either, or
both, of the included Listen files are changed.
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
