On 04/01/11 12:49, Keith Mitchell wrote:
One small nit/suggestion in create_client.py:
Use single quotes around the string on lines 340-1, and then you don't
need to escape the quotes inside.
OK.
Should the warning say: "installadm enable <service>", replacing
service with options.service_name?
I suppose it could; original thought was just to point them at the
command to use, but I suppose giving them something cut-n-pastable would
be better. Here's what the example output would look like:
# installadm create-client -e 0:14:4f:0:c6:7a -n dev-161-sparc
Creating SPARC configuration file
Warning: the installation service, dev-161-sparc, is disabled.
To enable it, use "installadm enable dev-161-sparc".
I'll change it to this.
Another nit: 333: enabledd -> enabled
Thanks.
-ethan
On 03/31/11 05:53 PM, Ethan Quach wrote:
All,
Can I please get a review for the following bugfix:
Webrev:
----------
http://cr.opensolaris.org/~equach/webrev.7031357/
Testing:
---------
1. Made sure create-client does not do anything wrt enablement of the
service regardless of its state.
2. Made sure create-client prints out a warning if the service is
disabled.
3. Made sure the 'refresh' method does not restart apache if neither
of the included Listen files are changed.
4. Made sure the 'refresh' method does restart apache if either, or
both, of the included Listen files are changed.
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
