Hi Karen.
Thanks for your quick reply.
On 04/ 5/11 11:51 PM, Karen Tung wrote:
Hi Jack,
I reviewed the changes to aimanifest.py and packaging changes:
--------------------------------------------------
usr/src/cmd/aimanifest/aimanifest.py
--------------------------------------------------
line 158-160: question: This format looks very similar to the format
that's default for the InstallLogger implementation. Is there a reason
why you want to set it here instead of use the default?
Yes. I don't need a full-blown time-stamp, and I want to use screen
space efficiently.
Aimanifest log lines are read into the auto-installer logfile, and so
will have the header from both the auto-installer and aimanifest programs.
line 185: Nit: I think you can just do the len(argv) in line 187. Why
specially
compute it here? I don't see len_argv being used elsewhere.
Thanks. Removed.
line 331: Since you are inside the "exception clause", I think just using
AIM_LOGGER.exception() will automatically log the whole trace. You don't
need to pass in anything.
exception() requires a message arg. The documentation says it needs to
be called from an exception handler or exception clause.
Also, you won't need line 332.
print_exc() will emit to the screen the traceback which otherwise would
get eaten by the "except StandardError as error" clause. For unexpected
exceptions, I want a screen traceback.
(Note: expected exceptions are all handled through handle_error(). )
-----------------------------------------------
usr/src/pkg/manifests/system-install-auto-install.mf
----------------------------------------------
line 33-34: since you are no longer going to be delivering a profile,
I don't think
you need these 2 lines anymore.
Yup. Thanks. Fixed.
Thanks again,
Jack
Thanks,
--Karen
On 04/ 5/11 05:19 PM, Jack Schwartz wrote:
Hi everyone.
Here is hopefully the last round of webrevs with significant changes
for Derived Manifest. (Li is still testing but is almost done. He
needs "final" bits to complete his testing.)
AI server changes are minimal, mostly fixes to bugs found by Li of QE.
vs previous webrev:
http://cr.opensolaris.org/~schwartz/110329.1/webrev.srv.3.4.diff/
vs slim_source:
http://cr.opensolaris.org/~schwartz/110329.1/webrev.srv.3/
AI client changes are a little more substantial, including bug fixes
found by Li, re-whacking of aimanifest for better logging, and
bugfixes to pathing.
vs previous webrev:
http://cr.opensolaris.org/~schwartz/110329.1/webrev.cli.2.3.diff/
vs AI-CUD gate*:
http://cr.opensolaris.org/~schwartz/110329.1/webrev.cli.3/
* Note: I pushed to AI-CUD gate at the time of first code review, so
the AI-CUD team could use my bits for testing.
I would be grateful for the following people to help with the review
as soon as possible. If you are named and can't review please let me
know ASAP.
Client side:
Matt: changes to dmm.py and new dmm_log_test unit test.
Drew: changes to mim.py and mim_errors.py
Karen: changes to aimanifest.py and packaging
Ginnie: changes to logger.py
Note: Dave M. blessed changes to rbac files before going on vacation.
Server side:
John: all changes
Thanks everyone for your time,
Jack
P.S. Notes: AI client webrev shows changes for auto_install.py in the
delta, but they are not my changes; ai_get_manifest.py is reverted
to what was there before I pushed originally.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
