Hi Matt. Thanks for your reply.
On 04/ 5/11 11:46 PM, Matt Keenan wrote:
It would be nice if, somewhere, there was a module with all of these kinds of definitions. Then if and when commonly used (and often hardcoded) items such as the default.xml path changed, the changes would be automatically propagated to all that need to know about them...Jack,Your changes look fine to me, only concern is with the logging test, but it's cud_ai concern rather than yours, we need to ensure the delivered default.xml conforms to the new ai.dtd as opposed to what'scurrently delivered in slim_source :-)
otherwise looks good.
Thanks Matt,
Jack
cheers Matt On 04/ 6/11 01:19 AM, Jack Schwartz wrote:Hi everyone. Here is hopefully the last round of webrevs with significant changes for Derived Manifest. (Li is still testing but is almost done. He needs "final" bits to complete his testing.) AI server changes are minimal, mostly fixes to bugs found by Li of QE. vs previous webrev: http://cr.opensolaris.org/~schwartz/110329.1/webrev.srv.3.4.diff/ vs slim_source: http://cr.opensolaris.org/~schwartz/110329.1/webrev.srv.3/ AI client changes are a little more substantial, including bug fixes found by Li, re-whacking of aimanifest for better logging, and bugfixes to pathing. vs previous webrev: http://cr.opensolaris.org/~schwartz/110329.1/webrev.cli.2.3.diff/ vs AI-CUD gate*: http://cr.opensolaris.org/~schwartz/110329.1/webrev.cli.3/ * Note: I pushed to AI-CUD gate at the time of first code review, so the AI-CUD team could use my bits for testing. I would be grateful for the following people to help with the review assoon as possible. If you are named and can't review please let me know ASAP.Client side: Matt: changes to dmm.py and new dmm_log_test unit test. Drew: changes to mim.py and mim_errors.py Karen: changes to aimanifest.py and packaging Ginnie: changes to logger.py Note: Dave M. blessed changes to rbac files before going on vacation. Server side: John: all changes Thanks everyone for your time, Jack P.S. Notes: AI client webrev shows changes for auto_install.py in the delta, but they are not my changes; ai_get_manifest.py is reverted to what was there before I pushed originally.
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
