Looks mostly ok. Just a few comments modulo what others found:
boot_archive_configure
398: Align with 397
install_transfer/__init__.py
70: remove
71: align block comment end with line 53
cpio.py
500: change back to .debug
505: change back to .debug
The reason I'd prefer these to be debug is to cut down on the spam DC
generates.
595: change to: if args is not None:
Otherwise push it!
-Drew
On 4/6/11 5:51 PM, Martin Widjaja wrote:
Hey Sanjay,
Thanks for finishing this up just in time for TI/TD put back...
This should really alleviate some stress off of Drew.. :-)
Thanks,
Martin
On 4/6/2011 4:05 PM, sanjay nadkarni wrote:
Please review the changes. This is a back port of the code that
exists in CUD_TI gate. A few other files have been added to the list
since I ran pep8 on the directories that I touched however webrev
does not appear to generate any changes spaces or tabs where changed.
One change that is captured in boot_archive_archive.py is the
increased number of inodes. This is in addition to the change made
recently to increase the size of the ram disk
http://cr.opensolaris.org/~nadkarni/bugfix_7001589/
Thanks
-Sanjay
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
