On 04/ 6/11 05:27 PM, Mary Ding wrote:
Sanjay:
You should run hg nits as some of the Copyright file are out of date.
Other than that, everything looks fine.
okay
On 04/ 6/11 05:42 PM, Virginia Wray wrote:
distro_const/checkpoints/__init__.py
-----------------------------------------------
update copyright
okay
transfer/info.py
------------------------
line 76: I think that was a typo on my part. I think _type was supposed
to be tran_type.
Nah..my bad. Fixed.
test_cpio.py
----------------
line 833: remove this line
test_ips.py
-----------------
update copyright - although there don't appear to be any changes.
However,
I noticed some ipkg.sfbay references, so we should probably correct
those.
I looked at this closer and there is quite a bit of brokeness wrt to
URLs. For example the URLs listed for mirrors no longer exist. It is
still included in the push list sine I have changed the perms of the
test files to be 644.
On 04/ 6/11 06:18 PM, Drew Fisher wrote:
Looks mostly ok. Just a few comments modulo what others found:
boot_archive_configure
398: Align with 397
install_transfer/__init__.py
70: remove
71: align block comment end with line 53
cpio.py
500: change back to .debug
505: change back to .debug
The reason I'd prefer these to be debug is to cut down on the spam DC
generates.
595: change to: if args is not None:
Okay to all the of the above.
Otherwise push it!
Will do soon.
-Sanjay
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
