Drew,
All looks fine to me, except:
usr/src/lib/install_transfer/info.py:
295 arg_info = self.get_children("args")
s/"args"/Args.ARGS_LABEL/
296 if arg_info:
297 if Image.IMAGE_SSL_KEY_LABEL in arg_info.arg_dict:
shouldn't "arg_info.arg_dict" be "arg_info[0].arg_dict", as in
lines 299& 302?
298 element.set(Image.IMAGE_SSL_KEY_LABEL,
299
arg_info[0].arg_dict[Image.IMAGE_SSL_KEY_LABEL])
300 if Image.IMAGE_SSL_CERT_LABEL in arg_info.arg_dict:
shouldn't "arg_info.arg_dict" be "arg_info[0].arg_dict", as in
lines 299& 302?
301 element.set(Image.IMAGE_SSL_CERT_LABEL,
302
arg_info[0].arg_dict[Image.IMAGE_SSL_CERT_LABEL])
303 element.set(Image.IMAGE_IMG_ROOT_LABEL, self.img_root)
304 element.set(Image.IMAGE_ACTION_LABEL, self.action)
305 element.set(Image.IMAGE_INDEX_LABEL, str(self.index))
306 return element
- Dermot
On 04/14/11 04:24, Drew Fisher wrote:
Good evening!
Could I please get a code review for some unittest fixes? I broke a few more
unittests with the TI/TD push.
http://cr.opensolaris.org/~drewfish/cr_7036435/
http://monaco.us.oracle.com/detail.jsf?cr=7036435
Things to note:
- the unittests found a place in the engine code I forgot to update with some
changed TI functionality. This has been addressed
- the changes in install_transfer/info.py might be another manifestation of
Sanjay's partial push last week. I remember him changing this exact code, but
the changes may not have made it for some reason.
- The changes to install_manifest/test/manifests/software.dtd and target.dtd
for the install_manifest tests are direct pick-ups of the files delivered in
install_manifest/dtd. There should be no reason to code review them.
Thanks for looking!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
