Thanks, Evan!
-Drew
On 4/14/11 9:34 AM, Evan Layton wrote:
Hey Drew,
Looks good ship it!
-evan
On 4/13/11 9:24 PM, Drew Fisher wrote:
Good evening!
Could I please get a code review for some unittest fixes? I broke a
few more
unittests with the TI/TD push.
http://cr.opensolaris.org/~drewfish/cr_7036435/
http://monaco.us.oracle.com/detail.jsf?cr=7036435
Things to note:
- the unittests found a place in the engine code I forgot to update
with some
changed TI functionality. This has been addressed
- the changes in install_transfer/info.py might be another
manifestation of
Sanjay's partial push last week. I remember him changing this exact
code, but
the changes may not have made it for some reason.
- The changes to install_manifest/test/manifests/software.dtd and
target.dtd for
the install_manifest tests are direct pick-ups of the files delivered in
install_manifest/dtd. There should be no reason to code review them.
Thanks for looking!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
