On 04/18/11 01:40 PM, Drew Fisher wrote:


On 4/18/11 2:31 PM, Keith Mitchell wrote:
On 04/18/11 01:25 PM, Drew Fisher wrote:
Good afternoon!

Could I please get a couple of eyes on the following code review?

http://cr.opensolaris.org/~drewfish/transfer_fixes/

7013385 <http://monaco.us.oracle.com/detail.jsf?cr=7013385> Unit test
failures in test_p5i.py
7009191 <http://monaco.us.oracle.com/detail.jsf?cr=7009191> Transfer
checkpoint does not raise correct exception when "contents" is not
correctly specified
7009181 <http://monaco.us.oracle.com/detail.jsf?cr=7009181> Transfer
checkpoint does not handle uninstall from a provided file list correctly
7005892 <http://monaco.us.oracle.com/detail.jsf?cr=7005892>
simple_log should log which IPS repos it try to install from and
setting post-install publisher


For the test_p5i.py fix, I went with Keith's idea of setting default
values for the publisher, URI and p5i path with using environment
variables to override the defaults should things change for
ipkg.us.oracle.com

For the simple_log output fix, here's a snippet of the output:

Hi Drew,

Does the fix show mirrors and secondary publishers as well?

No. It only shows the primary publisher.

That's probably not correct, especially since pkg(5) is removing the notion of "preferred" (what you call primary) publishers.

That notion really hasn't been correct for a while now.

It should show all publishers and origins/mirrors.
-Shawn
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to