Hi Drew -
Other than Keith and Sean's comments, looks ok.
thanks,
ginnie
On 04/18/11 02:25 PM, Drew Fisher wrote:
Good afternoon!
Could I please get a couple of eyes on the following code review?
http://cr.opensolaris.org/~drewfish/transfer_fixes/
7013385 <http://monaco.us.oracle.com/detail.jsf?cr=7013385> Unit test
failures in test_p5i.py
7009191 <http://monaco.us.oracle.com/detail.jsf?cr=7009191> Transfer
checkpoint does not raise correct exception when "contents" is not
correctly specified
7009181 <http://monaco.us.oracle.com/detail.jsf?cr=7009181> Transfer
checkpoint does not handle uninstall from a provided file list correctly
7005892 <http://monaco.us.oracle.com/detail.jsf?cr=7005892> simple_log
should log which IPS repos it try to install from and setting
post-install publisher
For the test_p5i.py fix, I went with Keith's idea of setting default
values for the publisher, URI and p5i path with using environment
variables to override the defaults should things change for
ipkg.us.oracle.com
For the simple_log output fix, here's a snippet of the output:
[mox:distro_const] > sudo ./distro_const build -p ba-config
manifest/proto_dc_ai_x86.xml
13:38:21 Build datasets successfully setup
13:38:21 Simple log:
/rpool/transfer_fixes/ai/logs/simple-log.2011-04-18.13:38
13:38:21 Detail Log:
/rpool/transfer_fixes/ai/logs/detail-log.2011-04-18.13:38
13:38:22 === Executing transfer-ips-install Checkpoint ===
13:38:22 Creating IPS image
13:38:31 Installing packages from
http://ipkg.us.oracle.com/solaris11/dev/
Deleting content cache
13:43:17 === Executing set-ips-attributes Checkpoint ===
13:43:17 Updating post-install publisher to
http://ipkg.us.oracle.com/solaris11/release/
<...>
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
