Drew: If they are not related to lang facet.xml, why are they move there ???
----- Original Message ----- From: [email protected] To: [email protected] Cc: [email protected], [email protected] Sent: Friday, April 22, 2011 1:58:40 PM GMT -08:00 US/Canada Pacific Subject: Re: [caiman-discuss] code review request for 7037378 They were not deleted. They were moved into the lang_facet.xml file. -Drew On 4/22/11 2:47 PM, Mary Ding wrote: > Drew: > > Why was the two lines related to zfs create and flush contents deleted ??? > Is that a mistake ??? > > > ----- Original Message ----- > From: [email protected] > To: [email protected] > Cc: [email protected] > Sent: Friday, April 22, 2011 12:50:41 PM GMT -08:00 US/Canada Pacific > Subject: Re: [caiman-discuss] code review request for 7037378 > > OK. Once more, now with xincludes! > > http://cr.opensolaris.org/~drewfish/cr_7037378/ > > Tested by building and starting an install of AI. Everything's peachy. > > -Drew > > On 4/22/11 9:25 AM, Dave Miner wrote: >> On 04/22/11 11:14 AM, Drew Fisher wrote: >>> Good Morning! >>> >>> Could I please get a code review for the following CR? >>> >>> 7037378<http://monaco.us.oracle.com/detail.jsf?cr=7037378> specify >>> locale facets in default DC manifests >>> >>> http://cr.opensolaris.org/~drewfish/cr_7037378/ >>> >> Fix is fine, though I would have given you extra credit if you'd done >> an xinclude like boot archive contents :-) >> >> Dave > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
