William,
common_profile.py
----------------
370: move import line to top of file
374-379: don't use try/except as a control structure. Be explicit with
os.geteuid()
if os.geteuid() == 0:
<use /system/volatile>
else:
<use /tmp>
Can you switch from using subprocess to solaris_install.Popen instead?
385-387 change to look something like this:
p = Popen.check_call(pargs, stdout=Popen.STORE, stderr=Popen.STORE)
os.unlink(profname)
return p.stderr
and the import line is:
from solaris_install import Popen
Otherwise, this looks ok to me.
-Drew
On 4/28/11 3:54 AM, William Schumann wrote:
Modified code to use 'svccfg apply -n' to validate, since it tolerates
missing 'type' attributes. Tested code and sample profile changes.
Please review changes.
http://cr.opensolaris.org/~wmsch/bug-7037229/
William
On 04/22/11 11:05 AM, William Schumann wrote:
On 04/21/11 08:10 PM, Dave Miner wrote:
William, your change is OK, though I'd note a general point in this
whole example file that the type attribute for propvals is not
required in a profile (and really shouldn't be used so that there
isn't the possibility of disagreement with the service manifest that
defines them and any resulting weird behavior), so I would like to
see them removed in order to provide a more concise and correct
example.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
