On 04/28/11 05:54 AM, William Schumann wrote:
Modified code to use 'svccfg apply -n' to validate, since it tolerates missing 
'type' attributes.  Tested code and sample profile
changes.

Please review changes.
    http://cr.opensolaris.org/~wmsch/bug-7037229/


A couple of nit-level things in common_profile.py:

29: Surprised you didn't use install_common.Popen

289: I'm not sure why you would _ the returned error, there's no translation we're going to have available for it. Wouldn't that have already been localized by svccfg itself?

Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to