Niall, Review for group #1.
On 04/21/11 02:51, Niall Power wrote:
1) Boot schema definitions and Data Object Cache support usr/src/lib/install_manifest/dtd/Makefile
- update copyright year
usr/src/lib/install_manifest/dtd/boot.dtd
- I'd prefer if this file was called boot_mods.dtd, matching the top-level element it contains, which is kind-of the precedent of the other files here. - file should have CDDL header and copyright - lines 22- 34. It's a bit confusing that these comments refer to one of the attributes of boot_entry and the two sub-elements. I'd prefer that the comment be broken into three separate comments. Also, "default_entry" attrib is not commented.
usr/src/lib/install_manifest/dtd/dc.dtd usr/src/lib/install_boot/boot_spec.py
- wrong copyright - line 1: I think we're just supposed to use "#!/usr/bin/python" for the she-bang line in modules - 122: should be "if self.default_entry is not None" - line 154: misleading comment - it also checks for existence of sub-element title_suffix - 175 - might be easier to just default to False instead of None? Then other code doesn't need to keep checking "if ...default_entry is not None"? - 202-203 - not needed - default_entry will have been set to None in __init__
usr/src/lib/install_boot/test/test_boot_spec.py (Tests)
- line 1: I think we're just supposed to use "#!/usr/bin/python" for the she-bang line in unit test files - Dermot _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
